Skip to content

Rename Available Commands to Main Commands#4975

Open
janniklasrose wants to merge 3 commits into
mainfrom
janniklasrose/rename-available-commands
Open

Rename Available Commands to Main Commands#4975
janniklasrose wants to merge 3 commits into
mainfrom
janniklasrose/rename-available-commands

Conversation

@janniklasrose
Copy link
Copy Markdown
Contributor

@janniklasrose janniklasrose commented Apr 15, 2026

Changes

Rename Available Commands to Main Commands

Why

If Management Commands and/or Permission Commands groups are present, it is a bit confusing from --help that they are also available.

before:

% databricks permissions --help
Usage:
  databricks permissions [flags]
  databricks permissions [command]

Available Commands
  get                   Get object permissions.
  set                   Set object permissions.
  update                Update object permissions.

Permission Commands
  get-permission-levels Get object permission levels.

after:

% ./cli permissions --help
Usage:
  databricks permissions [flags]
  databricks permissions [command]

Main Commands
  get                   Get object permissions.
  set                   Set object permissions.
  update                Update object permissions.

Permission Commands
  get-permission-levels Get object permission levels.

Flags:
  -h, --help   help for permissions

Tests

manual, see Why section above ^

@janniklasrose janniklasrose requested a review from pietern April 15, 2026 09:57
@janniklasrose janniklasrose marked this pull request as ready for review April 15, 2026 10:58
janniklasrose
janniklasrose commented Apr 15, 2026
View reviewed changes
Comment thread cmd/cmd.go
{
ID: mainGroup,
Title: "Available Commands",
Title: "Main Commands",
Copy link
Copy Markdown
Contributor Author

@janniklasrose janniklasrose Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now a bit inconsistent with how Cobra behaves if there are no groups (it still prints Available Commands: in that case).

We could also do "Available Commands (Main)", "Available Commands (Permissions)", here

Copy link
Copy Markdown
Contributor

@pietern pietern May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this also applicable to the account commands?

Copy link
Copy Markdown
Contributor

@pietern pietern May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inconsistency with Cobra is unfortunate. Any chance we can address that as well?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 15, 2026

Approval status: pending

/acceptance/pipelines/ - needs approval

Files: acceptance/pipelines/databricks-cli-help/output.txt
Suggested: @kanterov
Also eligible: @lennartkats-db, @jefferycheng1

General files (require maintainer)

Files: acceptance/cmd/unknown-subcommand/output.txt, acceptance/cmd/workspace/secrets/output.txt, cmd/cmd.go
Based on git history:

  • @pietern -- recent work in cmd/

Any maintainer (@andrewnester, @anton-107, @denik, @pietern, @shreyas-goenka, @simonfaltum, @renaudhartert-db) can approve all areas.
See OWNERS for ownership rules.

@pietern pietern requested a review from simonfaltum May 8, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pietern pietern Awaiting requested review from pietern

@simonfaltum simonfaltum Awaiting requested review from simonfaltum

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@janniklasrose @pietern